Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1846] only show buyable trains in EMR #10186

Merged
merged 1 commit into from
Jan 25, 2024
Merged

[1846] only show buyable trains in EMR #10186

merged 1 commit into from
Jan 25, 2024

Conversation

benjaminxscott
Copy link
Contributor

@benjaminxscott benjaminxscott commented Jan 25, 2024

Fixes #10185

Before clicking "Create"

  • Branch is derived from the latest master
  • [NA] Add the pins label if this change will break existing games
  • Code passes linter with docker compose exec rack rubocop -a
  • Tests pass cleanly with docker compose exec rack rake

Implementation Notes

  • Explanation of Change

In EMR when a corp has enough money for a "weaker" variant but not enough for a pricer variant, the president is allowed to sell shares to afford the pricier one.

In this case, we should only show trains that can be purchased at those times

  • Screenshots
    image

  • Any Assumptions / Hacks

@michaeljb michaeljb merged commit 4630c2a into tobymao:master Jan 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1846] during EMR step, only the more expensive variant was offered
2 participants